fix: detect virtualenvs on Windows #470
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@mmarchetti also mentioned that #207 needed to merge; we may need both changes. |
mmarchetti
approved these changes
Aug 30, 2023
Contributor
mmarchetti
left a comment
mmarchetti
left a comment
There was a problem hiding this comment.
The change looks good. There are some unrelated CI issues we will need to look into before merging.
Contributor
|
The CI issues are because repo secrets aren't available when running actions from a fork. I gave you write access to the repo and also created a local branch from the one in this PR. I think a PR will need to be opened from the local branch in order to pass CI. |
Contributor
|
Closing in favor of #472 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Resolves #469
Type of Change
Automated Tests
Have not yet added a test, wasn't sure where it should go, but happy to add one.
Checklist