Skip to content

Conversation

@schloerke
Copy link
Collaborator

@schloerke schloerke commented Aug 27, 2024

Fixes #1649

Would also cover the case from #1332

  • Fix bug found by mypy

@schloerke
Copy link
Collaborator Author

🎉

Run make ci-check-mypy-can-run
-------- Checking types with mypy -----------
mypy shiny
shiny/render/_data_frame_utils/_selection.py:154: error: invalid syntax  [syntax]
Found 1 error in 1 file (errors prevented further checking)
make: *** [Makefile:232: ci-check-mypy-can-run] Error 2

@schloerke schloerke marked this pull request as ready for review August 27, 2024 20:52
@schloerke
Copy link
Collaborator Author

The CI failures are related to random chat test failures independent of this PR.

Merging as the goal of this PR has been achieved.

@schloerke schloerke merged commit f643a8f into main Aug 28, 2024
@schloerke schloerke deleted the mypy_checks branch August 28, 2024 02:59
schloerke added a commit to machow/py-shiny that referenced this pull request Sep 5, 2024
* main:
  CI(deploy): Add more installation configs to surface failure cause (posit-dev#1658)
  `Chat.messages()` no longer trims messages by default (posit-dev#1657)
  tests(controllers): Split _controls.py into separate files (posit-dev#1652)
  Chat tweaks (posit-dev#1607)
  docs: Add modal_show/remove examples (posit-dev#1628)
  Delay sending of chat UI messages until reactive graph is flushed (posit-dev#1593)
  ci(remove future behavior warning): Set the `asyncio_default_fixture_loop_scope` to `fixture` (posit-dev#1655)
  bug: Verify mypy can run on CI (posit-dev#1650)
  Fix CI install failures on Windows (posit-dev#1651)
  Quartodoc 0.7.6 (posit-dev#1636)
  Allow `@chat.transform_assistant_response` function to return `None` (posit-dev#1641)
  feat: Support templates with `_template.json` metadata (posit-dev#1631)
  Fix KeyError when serving static files (posit-dev#1648)
  tests(navsets): Add navsets kitchensink tests (posit-dev#1602)
  Change default claude model to 3.5 sonnet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[regression] Mypy fails with shiny==1.0.0

2 participants