Chat tweaks #1607
Merged
Chat tweaks #1607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
The failing tests are real, at least some of them. Need to update the tests probably. |
cpsievert
reviewed
Aug 6, 2024
17 tasks
cpsievert
reviewed
Aug 9, 2024
Without this it's quite difficult to figure out where the underlying exception occurred
cpsievert
reviewed
Aug 27, 2024
…t introduce a 'busy' message attribute that indicates busy status on the message icon
Collaborator
|
Currently on this branch, when rendering a code block from user input, long lines get cut off to the left and there is no way to scroll. For example: 
I don't know if this is the best solution, but I found that if I turn off 
|
… show bouncing ball below message after a couple seconds of streaming
Collaborator
Collaborator
|
Reviewed in person with Joe. |
schloerke
added a commit
to machow/py-shiny
that referenced
this pull request
Sep 5, 2024
* main: CI(deploy): Add more installation configs to surface failure cause (posit-dev#1658) `Chat.messages()` no longer trims messages by default (posit-dev#1657) tests(controllers): Split _controls.py into separate files (posit-dev#1652) Chat tweaks (posit-dev#1607) docs: Add modal_show/remove examples (posit-dev#1628) Delay sending of chat UI messages until reactive graph is flushed (posit-dev#1593) ci(remove future behavior warning): Set the `asyncio_default_fixture_loop_scope` to `fixture` (posit-dev#1655) bug: Verify mypy can run on CI (posit-dev#1650) Fix CI install failures on Windows (posit-dev#1651) Quartodoc 0.7.6 (posit-dev#1636) Allow `@chat.transform_assistant_response` function to return `None` (posit-dev#1641) feat: Support templates with `_template.json` metadata (posit-dev#1631) Fix KeyError when serving static files (posit-dev#1648) tests(navsets): Add navsets kitchensink tests (posit-dev#1602) Change default claude model to 3.5 sonnet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chat input is rendered like plain text today. With this change, it becomes Markdown, same as the output except raw HTML tags are escaped. I think this is pretty nice, especially for code, but if we want to be more like ChatGPT we could treat it as plaintext but preserve breaks. (Edit: @wch suggests we make this configurable)
I also made a subtle but important change to the NotifyException, it now chains the underlying exception (
raise x from y). We should do a sweep sometime to make sure we do this everywhere; it's so hard to debug without being able to trace back to the original exception.