Send busy/idle at the right times #1380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, busy/idle messages were sent for each output/effect. That isn't correct, those messages are only supposed to be sent when the session as a whole becomes busy/idle.
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
No, they’re unrelated. This one changes the messages that are sent, #1373 has the right messages in the right order but they’re sent with the wrong timing. |
Collaborator
|
Looks good to me, but we're getting playwright errors. Anyone know if they're real issues? |
Collaborator
Author
|
@wch Some are related to a missing |
…ed) from 5s to 30s busy_indicator app takes minimum 4s to compute. Give a little bit extra time for CI to avoid adding a static wait time.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Collaborator
|
Bypassing GH merge queue as the single test failure was due to a DataFrame error unrelated to busy/idle changes |
schloerke
added a commit
that referenced
this pull request
May 20, 2024
* data_view_meta: Add demo apps for `update_sort()` and `update_filter()` Add `update_sort()` and `update_filter()` to DF bug(output transformer): fix transformer auto-registration (#1394) fix: Add wait till pulse animation has started (#1393) bug(test-deploy): Add retries for deploy tests (#1392) Add busy indicator tests (#1391) Yield to give "synchronous" writes a chance to complete (#1388) chore(busy indicator): Update busy indicator css files (#1389) `ColumnFilter` and `ColumnSort` should use `col: num` and not `id: str` for consistency Lints Have `.data_view()` use `.data_view_info()` information for consistent subsetting feat(cli): Add `shiny --version` (#1387) fix(selectize): Accept jsonifiable values in `options` dictionary (#1382) bug(data frame): Use `<ID>_data_view_rows` (#1386) test(data frame): Verify that data frame's outputs are reset before moving forward (#1383) Send busy/idle at the right times (#1380) feat(data frame): Restore `input.<ID>_selected_rows()`. Rename `input.<ID>_data_view_indices` to `input.<ID>_data_view_rows` (#1377) Apply suggestions from code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, busy/idle messages were sent for each output/effect. That isn't correct, those messages are only supposed to be sent when the session as a whole becomes busy/idle.
Fixes #1379