Skip to content

api(render.data_frame): Separate mode= into selection_mode= and editable= #1248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Apr 2, 2024
Merged

api(render.data_frame): Separate mode= into selection_mode= and editable= #1248

merged 26 commits into from
Apr 2, 2024

Conversation

@schloerke
Copy link
Collaborator

@schloerke schloerke commented Mar 26, 2024 •
edited
Loading 

class DataGrid():
    def __init__(
        ....
        editable: bool = False,
        selection_mode: Literal["none", "row", "rows"] = "none",
        ....
class DataGrid():
    def __init__(
        ....
        editable: bool = False,
        selection_mode: Literal["none", "row", "rows"] = "none",
        ....

... with room to grow with "col", "cols", and "rect".

wch
wch reviewed Mar 26, 2024
View reviewed changes
@schloerke
Merge branch 'main' into split_df_mode
702f1e9 
* main:
  feat: Create `Session.set_message_handler(name, handler)` (#1253)
  Fix input name
  Enable error console when running locally. (#1060)
  test: Update test to use variable, not capture stdout (#1236)
@schloerke
Rearrange logic and update comment to say editable and selection_mode…
ac7f2da 
… can not _currently_ be enabled
@schloerke
Return a tuple, not a Sequence from helper method.
41677b0
@schloerke
Code suggestions
6eba7ed
@schloerke
selection_mode= -> selection_modes=
d37d6f9
@schloerke
type lint
035b9f1
@schloerke schloerke requested a review from wch March 27, 2024 21:11
@schloerke schloerke marked this pull request as ready for review March 27, 2024 21:12
@schloerke schloerke mentioned this pull request Mar 28, 2024
Closed
72 tasks
@schloerke
Merge branch 'main' into split_df_mode
a8f34ab 
* main:
  test(CI): Add merge queue support for faster PR testing (#1265)
  fix(panel_conditional): Include `.shiny-panel-conditional` class (#1257)
wch
wch reviewed Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@wch wch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments. Note that I feel strongly about the argument name, but the other stuff isn't as important.

@schloerke schloerke requested a review from wch April 1, 2024 19:12
@schloerke
Copy link
Collaborator Author

schloerke commented Apr 2, 2024

Going to merge. Any changes can be made in a followup PR 😄

@schloerke schloerke added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit 9570af4 Apr 2, 2024
@schloerke schloerke deleted the split_df_mode branch April 2, 2024 13:45
@schloerke schloerke mentioned this pull request Apr 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wch wch Awaiting requested review from wch

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@schloerke @wch