Enable error console when running locally. #1060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wch
force-pushed
the
dev-mode-error-console
branch
from
b93a1ff to
a65ae2c
Compare
wch
force-pushed
the
dev-mode-error-console
branch
from
a65ae2c to
cf26fa3
Compare
Collaborator
|
I wonder if we should make it based on |
Collaborator
|
After discussion with @wch in person, the important thing we want to ensure is that Connect never shows the error console by default, so we should write a automated test that verifies that and this PR can be merged as-is. |
schloerke
added a commit
that referenced
this pull request
Mar 28, 2024
* main: test(CI): Add merge queue support for faster PR testing (#1265) fix(panel_conditional): Include `.shiny-panel-conditional` class (#1257) feat: Create `Session.set_message_handler(name, handler)` (#1253) Fix input name Enable error console when running locally. (#1060) test: Update test to use variable, not capture stdout (#1236) test: Fix deploys for shinyapps.io and connect (#1224) chore(test): Playwright test refactors and clean up (#1204)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the error console when running shiny apps locally.
When apps are run locally, they are launched with
shiny run; when they are run on a server (like Connect) they are launched withuvicorn, and in that case the error console will not be enabled.