Fix express.ui.update_date andexpress.ui.update_text links
#1192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wch
commented
Mar 5, 2024
Comment on lines
-123
to
-124
| - name: express.ui.update_text_area | ||
| dynamic: "shiny.ui.update_text" |
Collaborator
Author
There was a problem hiding this comment.
This one is different because it has dynamic: "shiny.ui.update_text", but removing it did not seem to change the resulting link or web page when I tested locally.
gadenbuie
approved these changes
Mar 5, 2024
Collaborator
gadenbuie
left a comment
gadenbuie
left a comment
There was a problem hiding this comment.
Looks good to me, thanks!
schloerke
added a commit
that referenced
this pull request
Mar 6, 2024
* main: (35 commits) test: Speed up tests by using single page. Do not attempt deploys job unless conditions are valid (#1197) ci: Run `playwright-examples` on Python 3.12 as well (#1195) Shiny preset style updates and nudges (#1176) tests: Upload trace on failed tests (#1196) Fix datetime input in airmass example app (#1194) Better docs for `render.download` (#1193) Render `shiny.min.css` using `bs_theme()` (#1191) Fix `express.ui.update_date` and`express.ui.update_text` links (#1192) Use `cast()` for asgiref types only when type checking (#1190) Remove uvicorn and click dependencies in Emscripten (#1187) Remove asgiref run-time dependency (#1183) Install dev-shinylive via Makefile (#1184) Put all "Other Changes" items into one section Use consistent formatting for items in changelog Don't run playwright-deploys tests on release tests(resolve-id): Update window size to ensure tooltip is visible (#1179) Setup dev version 0.8.0.9000 (#1181) Bump version to 0.8.0 Revert API changes made in `Selected rows method` #1121 (#1174) Make autoreload work on codespaces (#1167) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the Express API docs, the
update_dateandupdate_textitems point to the non-Express functions:This PR fixes them, and it also simplifies the config file by removing
dynamic: true, which I believe is no longer needed.