Make autoreload work on codespaces #1167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to get past GitHub Codespaces giving a 404 between 10-20% of the time when hitting the Run Shiny App button
Turns out devcontainers don't let you do this anyway. You can't use devcontainer.json to make ports public.
wch
reviewed
Mar 2, 2024
| # correctly proxy through this request, but give a 404 when the redirect is | ||
| # followed and app_url is requested. With the sleep, both requests tend to | ||
| # succeed reliably. | ||
| await asyncio.sleep(1) |
Collaborator
There was a problem hiding this comment.
I just want to check: it doesn't take this code path when developing locally, right?
schloerke
added a commit
that referenced
this pull request
Mar 6, 2024
* main: (35 commits) test: Speed up tests by using single page. Do not attempt deploys job unless conditions are valid (#1197) ci: Run `playwright-examples` on Python 3.12 as well (#1195) Shiny preset style updates and nudges (#1176) tests: Upload trace on failed tests (#1196) Fix datetime input in airmass example app (#1194) Better docs for `render.download` (#1193) Render `shiny.min.css` using `bs_theme()` (#1191) Fix `express.ui.update_date` and`express.ui.update_text` links (#1192) Use `cast()` for asgiref types only when type checking (#1190) Remove uvicorn and click dependencies in Emscripten (#1187) Remove asgiref run-time dependency (#1183) Install dev-shinylive via Makefile (#1184) Put all "Other Changes" items into one section Use consistent formatting for items in changelog Don't run playwright-deploys tests on release tests(resolve-id): Update window size to ensure tooltip is visible (#1179) Setup dev version 0.8.0.9000 (#1181) Bump version to 0.8.0 Revert API changes made in `Selected rows method` #1121 (#1174) Make autoreload work on codespaces (#1167) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes Shiny detect that it's running on Codespaces, where the browser can't just point to
http://127.0.0.1:{autoreload-port}and expect to succeed. Instead, a proxy URL is used. See Forwarding ports in your codespace.Note that this alone is not enough to make autoreload work quite right on codespaces. The Shiny app will try to connect to the autoreload websocket server and fail. This is because Codespace's forwarded ports are private by default, and need you to access each proxy hostname via HTTP document load first so it can set some cookies and whatnot. A forthcoming PR for pyshiny-vscode will try to address this.
Update: Here's the corresponding pyshiny-vscode PR posit-dev/shiny-vscode#27