feat: use v1 api in get_jobs()
#343
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Switch to using the
v1API forget_jobs().Fixes #340
Approach
The data returned by the old unversioned endpoint and the v1 endpoint (which has been around since 2022) differs. I adjusted the
ptypeto match the new endpoint, which mostly processes the old data correctly. To support this, I added the following:ptypecolumn order inparse_connectapi_typed(), to make the returned data nice and consistent looking. :)status(new) fromfinalized(old). We cannot fully computestatus. The oldfinalized == FALSEcorresponds tostatus == 0, butfinalized == TRUEcorresponds tostatuses1and2, so in that casestatusisNA.vctrscast from integer to character.Tests added:
httptest, which uses real responses captured from the old and new endpoints for the same piece of content. Checks that common columns are identical, and manually checks thestatuscolumn for each.Checklist
NEWS.md(referencing the connected issue if necessary)? NEEDdevtools::document()?