Runtime Version Scanner: Dynamically load EOL versions; improve documentation #246
Conversation
toph-allen
requested review from
nealrichardson,
fizzboop,
dotNomad,
cgraham-rs and
mconflitti-pbc
| "version. The content list will show content running an older version than ", | ||
| "the one selected in the corresponding dropdown menu in the sidebar. ", | ||
| "The menus include options to show content running Python outside of the ", | ||
| "official support window, and R outside of the tidyverse support window." |
There was a problem hiding this comment.
The filter selector says "EOL" not "support window", so we should use "end of life (EOL)" somewhere in here. (Saying "support window" too is fine if you want, maybe that's helpful in explaining what EOL is, up to you.)
There was a problem hiding this comment.
I agree — I used "EOL" in the sidebar because it works much better width-wise in a dropdown alongside entries that say "< 3.4.1" etc. Connecting those things together here makes sense.
| @@ -256,6 +315,10 @@ server <- function(input, output, session) { | |||
| ) | |||
| }) | |||
|
|
|||
| observeEvent(input$show_runtime_help, { | |||
| showModal(runtime_help_modal()) | |||
There was a problem hiding this comment.
I'm not sure how exactly you control this, but I loaded one of the versions of this you deployed, and while the table was loading data (the spinner thing was going), I figured I'd check out the modal. But when I clicked, nothing happened. So I kept clicking. When the table finally rendered, the modal opened--actually, one for every click!
There's probably a way to make it not be blocked by the table loading, but IDK what that would be.
There was a problem hiding this comment.
Yeah, I noticed the same behavior. I'll see if there's a way to finesse that at all. Loading the usage data is async; perhaps I need to make all the loading async.
Of course, async here means actually using plan(multisession) — do you think that's a bad thing to do on Connect? It seems to work fine.
There was a problem hiding this comment.
No idea. Would be good to know (and share!)
There was a problem hiding this comment.
I've given it a try! I'll post about it tomorrow more broadly.
Co-authored-by: Neal Richardson <[email protected]>
…/connect-extensions into toph/rvs-documentation
|
@nealrichardson I've addressed your feedback here. I'm having some issues migrating to Better that than holding this PR open and increasing scope :) [edit] David helped me find an easy way to do it. |
update-manifestcommand to help with updating the manifest. It doesn't allow you to add new files, that's still a bit fiddly, but it does the most common most fiddly things quite well.Play with this version (Posit-private links)
Fixes #245
Fixes #241