-
Notifications
You must be signed in to change notification settings - Fork 3
Runtime Version Scanner: Respond to feedback from user testing #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions
title = "Filters", | ||
|
||
div( | ||
"Runtimes", | ||
tooltip( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea: what if you put the tooltip on the "Runtime Version Scanner" title? (Or make it a modal popup.) Then you can explain the whole app in one place. I'm thinking also of the "Please select cutoff versions of R, Python, or Quarto." message in the main area, which seems out of place, but you could just explain everything in one place instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea! I think if I'm explaining the whole app, having it as a modal popup is nicer than a tooltip.
), | ||
p( | ||
"Versions in italic are no longer available on the server." | ||
) | ||
) | ||
) | ||
), | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to defer this idea, but you could add a button that is like "show EOL runtimes only" that sets the filter values to the right things (EOL python, out of tidyverse support for R), as a shortcut to get there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I definitely think a "proper EOL runtimes" filter mode is a good addition for a v1 release! I'm gonna target it in a follow-up PR for the end of the week.
It may not be a big deal given what this extension is trying to solve for users but I think it may make sense to have an option to do an inclusive comparison of the highest version in each runtime dropdown. For example: The top python version is 3.13.3 but you cannot view content using that since the comparison is strictly less than the selected version. Other than this small thing everything is working great! |
Yeah. That filter would be equivalent to "All Python content". I think that distinction (inclusive vs exclusive) might be difficult to message around in the UI, but perhaps just adding an additional custom item to the dropdown saying "Any Python Version", "Any R Version", etc., as the last item, would accomplish that. |
Looking at the feedback — I'm going to make minor adjustments in this PR ("Views Window" text, timestamp column width) and make the other adjustments in a follow-up PR later this week (move app docs to modal tooltip on the app title, add a checkbox for "proper EOL versions", add "any {runtime} version" option to cutoff filter dropdown). (cc @nealrichardson @mconflitti-pbc, thank you both for the reviews!) |
- Update date range inputs - Update blank version column display - Increase width of Last Published column
Makes the following changes from the previous version:
future::plan(multisession)
which might be bad on Connect? 🤔Available here: