Skip to content
This repository was archived by the owner on Jun 3, 2024. It is now read-only.

Updating CI Python images #910

Merged
merged 6 commits into from
Feb 1, 2021
Merged

Updating CI Python images #910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
272d3d9
trigger buil
Marc-Andre-Rivet Dec 17, 2020
adf1887
3.76 -> 3.6
Marc-Andre-Rivet Dec 17, 2020
83e1aee
trigger build
Marc-Andre-Rivet Dec 17, 2020
66aad75
remove `inni001` numbers now being processed correctly by Chrome
Marc-Andre-Rivet Dec 17, 2020
bb055d6
Update config.yml
Marc-Andre-Rivet Dec 18, 2020
a66dc5e
Merge branch 'dev' into sanity-browser-capabilities
alexcjohnson Feb 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
lint-unit-37: &lint-unit
working_directory: ~/project
docker:
- image: circleci/python:3.7.6-stretch-node-browsers
- image: circleci/python:3.7.9-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand Down Expand Up @@ -50,7 +50,7 @@ jobs:
lint-unit-36:
<<: *lint-unit
docker:
- image: circleci/python:3.6.9-stretch-node-browsers
- image: circleci/python:3.6.12-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand All @@ -60,7 +60,7 @@ jobs:
lint-unit-27:
<<: *lint-unit
docker:
- image: circleci/python:2.7-stretch-node-browsers
- image: circleci/python:2.7.18-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand All @@ -70,7 +70,7 @@ jobs:
build-dash-37: &build-dash
working_directory: ~/project
docker:
- image: circleci/python:3.7.6-stretch-node-browsers
- image: circleci/python:3.7.9-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand Down Expand Up @@ -116,7 +116,7 @@ jobs:
build-dash-36:
<<: *build-dash
docker:
- image: circleci/python:3.6.9-stretch-node-browsers
- image: circleci/python:3.6.12-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand All @@ -126,7 +126,7 @@ jobs:
build-dash-27:
<<: *build-dash
docker:
- image: circleci/python:2.7-stretch-node-browsers
- image: circleci/python:2.7.18-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand All @@ -136,7 +136,7 @@ jobs:
test-37: &test
working_directory: ~/project
docker:
- image: circleci/python:3.7.6-stretch-node-browsers
- image: circleci/python:3.7.9-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand Down Expand Up @@ -172,7 +172,7 @@ jobs:
test-36:
<<: *test
docker:
- image: circleci/python:3.6.9-stretch-node-browsers
- image: circleci/python:3.6.12-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand All @@ -183,7 +183,7 @@ jobs:
test-27:
<<: *test
docker:
- image: circleci/python:2.7-stretch-node-browsers
- image: circleci/python:2.7.18-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand All @@ -194,7 +194,7 @@ jobs:
test-legacy-37: &test-legacy
working_directory: ~/project
docker:
- image: circleci/python:3.7.6-stretch-node-browsers
- image: circleci/python:3.7.9-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand Down Expand Up @@ -231,7 +231,7 @@ jobs:
test-legacy-36:
<<: *test-legacy
docker:
- image: circleci/python:3.6.9-stretch-node-browsers
- image: circleci/python:3.6.12-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand All @@ -241,7 +241,7 @@ jobs:
test-legacy-27:
<<: *test-legacy
docker:
- image: circleci/python:2.7-stretch-node-browsers
- image: circleci/python:2.7.18-stretch-node-browsers
auth:
username: dashautomation
password: $DASH_PAT_DOCKERHUB
Expand Down
10 changes: 1 addition & 9 deletions tests/integration/input/test_number_input.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,8 @@

def test_inni001_invalid_numbers(ninput_app, dash_dcc):
dash_dcc.start_server(ninput_app)
for invalid_number in (
"10e10000",
"e+++eeeeeE-",
"120.2.33",
"12-.3",
"-3.3.3",
"0..0",
):
for invalid_number in ("10e10000", "e+++eeeeeE-", "12-.3"):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

120.2.33
-3.3.3
0..0

In Chrome 87 the above entries get processed into valid numbers as the invalid characters are simply removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

120.2.33 -> 120.233
-3.3.3 -> -3.33
0..0 -> 0.0

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting - what "removed" means is those characters are not accepted into the input. You type them and they just don't appear.

Begs the question why they still allow you to type 10e10000 - if they know to refuse a second decimal point, why don't they also refuse another zero past 10e100? There's no way to continue typing and turn that into a valid number. Likewise 12-.3 makes no sense at all. Really the only non-numbers they need to allow you to type are incomplete numbers, so I'd probably just put a few of those in and take out these others. Like perhaps -., 12e-. Otherwise we'll just see this problem again when they tighten up their logic further.

for debounce in ("false", "true"):

elem = dash_dcc.find_element("#input_{}".format(debounce))
assert not elem.get_attribute("value"), "input should have no initial value"

Expand Down