Updating CI Python images #910
Conversation
Marc-Andre-Rivet
requested review from
alexcjohnson and
rpkyle
as code owners
| "-3.3.3", | ||
| "0..0", | ||
| ): | ||
| for invalid_number in ("10e10000", "e+++eeeeeE-", "12-.3"): |
There was a problem hiding this comment.
120.2.33
-3.3.3
0..0
In Chrome 87 the above entries get processed into valid numbers as the invalid characters are simply removed
There was a problem hiding this comment.
120.2.33 -> 120.233
-3.3.3 -> -3.33
0..0 -> 0.0
There was a problem hiding this comment.
Oh interesting - what "removed" means is those characters are not accepted into the input. You type them and they just don't appear.
Begs the question why they still allow you to type 10e10000 - if they know to refuse a second decimal point, why don't they also refuse another zero past 10e100? There's no way to continue typing and turn that into a valid number. Likewise 12-.3 makes no sense at all. Really the only non-numbers they need to allow you to type are incomplete numbers, so I'd probably just put a few of those in and take out these others. Like perhaps -., 12e-. Otherwise we'll just see this problem again when they tighten up their logic further.
.circleci/config.yml
Outdated
| @@ -98,7 +98,7 @@ jobs: | |||
| . venv/bin/activate && mkdir packages | |||
| set -eo pipefail | |||
| # build main dash | |||
| git clone --depth 1 https://github.com/plotly/dash.git dash-main | |||
| git clone -b browser-capabilities --depth 1 https://github.com/plotly/dash.git dash-main | |||
There was a problem hiding this comment.
@Marc-Andre-Rivet Are we planning to keep this (cloning from a branch) going forward, or just for testing here?
There was a problem hiding this comment.
This is just to validate that the changes in plotly/dash#1507 don't break any tests. At least, not in ways we can't explain / fix.
Companion to plotly/dash#1507
Need to revert back dash branch when merged.