Fix non-integer range comparisons

[herndlm]

Closes #118
Closes #119

The problem is that range types are only supported for ints. See also https://phpstan.org/r/4c476dc8-d156-4f32-a733-207ba74133c5

If those assertions would be called with anything else, e.g. a float, the extensions would not add any additional type information and therefore lead to the errors described with strict-rules enabled.

[herndlm]

Wait, I'm gonna take a second look if there's not something to improve in the TypeSpecifier instead that would benefit PHPStan itself..

[dragosprotung]

I see that there are specific exceptions for integer types.

What about cases like:

function test(DateTimeInterface $value): void
{
    Assert::greaterThan($value, new DateTimeImmutable('now'));
}

[herndlm]

I see that there are specific exceptions for integer types.

What about cases like:

function test(DateTimeInterface $value): void
{
    Assert::greaterThan($value, new DateTimeImmutable('now'));
}

It's fine, because what I basically do is disabe the type specifying extension for everything that is not an int by not generating an expression that PHPStan would use to determine types. Which in term is used to determine the impossible-check-type-calls which would lead to those errors you reported.

I did not find a better fix, I think PHPStan is specifying types as good as it can and there is just no more type info for non-ints. And the only range-types supported here are ints as fare as I know. But I added DateTime test cases too, just in case :)

Still not a 100% happy though, I'd like to debug the impossible-check-helper too before keeping it like this.

[herndlm]

@ondrejmirtes sorry to bother you, wanted to ask you about your opinion.

The problem here is that a MixedType with subtracts is considered a super type of the given FloatType in https://github.com/phpstan/phpstan-src/blob/1.4.7/src/Rules/Comparison/ImpossibleCheckTypeHelper.php#L215

I'm just wondering if this is correct or if you think there's a bug in PHPStan. The answer seems to be coming from the subtracted UnionType that is giving a no which get's negated in the MixedType.

More details about the Union:
IntegerRange is not (trinary -1) considered to be a super type of FloatType (should it be maybe maybe via https://github.com/phpstan/phpstan-src/blob/1.4.7/src/Type/IntegerRangeType.php#L237 as would be an IntegerType?)
ConstantBooleanType is not (trinary -1) considered to be super of FloatType
NullType is not (trinary -1) considered to be a super type of FloatType

UPDATE: Yeah I think the IntegerRangeType is not playing nice with the FloatType on super type detection. I'll create a PR in phpstan

[herndlm]

As mentioned in the other PR I was wrong xD I think PHPStan is behaving correctly then and as long as Ondrej doesn't have a better idea I'll go with the changes here :)

[ondrejmirtes]

What about mixed or float|int? Do they demonstrate this bug or not?

[herndlm]

I assume you're trying to find out if I should use !(new IntegerType())->isSuperTypeOf($valueType)->yes() instead? :)
Apparently they are not affected, but I need to be able to use it with int|null to not break e.g. nullOrRange. If that makes sense. I'm not sure what the best solution for that is. I'm not sure if I fully understood already why it doesn't work, I need to take a closer look

[herndlm]

Aaah, I understand why. At that point, when the expression is built, it is still the int|null union of course..

[herndlm]

We're tryin to fix this in PHPStan itself, see #127 (comment)

[ondrejmirtes]

The tests here would still be useful.

[herndlm]

For sure, but they are currently failing?

[ondrejmirtes]

...to merge them once this is fixed 😊

[herndlm]

of course! sorry, misunderstood you :)