Skip to content

Fix IntegerRange-FloatType subtype detection #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix IntegerRange-FloatType subtype detection #1048

wants to merge 1 commit into from

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Mar 4, 2022 •
edited
Loading

Still not sure about the strict comparison of IntegerRange and Float unfortunately. That should stay false I guess argh

Inspired by phpstan/phpstan-webmozart-assert#120

@herndlm herndlm marked this pull request as draft March 4, 2022 12:00
@herndlm
Copy link
Contributor Author

herndlm commented Mar 4, 2022 •
edited
Loading

On second thought, yeah, the comparison needs to stay false. Ok then and sorry for the noise..

@herndlm herndlm closed this Mar 4, 2022
@herndlm herndlm deleted the fix-integerrange-float-subtype-detection branch March 4, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@herndlm