Add PHP 8 testcase and migrate to github actions #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
force-pushed
the
feature/github-actions
branch
from
c02c626 to
feac52f
Compare
dbu
reviewed
Jan 22, 2021
There was a problem hiding this comment.
looks good, one tiny request.
RE the title: the "nightly" was used to build with php 8 because php 8 stable was not available yet. so we did test with php 8 already. (of course its better to say 8.0 now that it is out and available - just to note that this pull request does not change the supported php versions of the library)
dbu
reviewed
Jan 22, 2021
dbu
reviewed
Jan 22, 2021
|
I applied your suggestion, tests are green: checks |
|
thanks! |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alexander-schranz#1 -> checks