Skip to content

Add PHP 8 compatibility and Use github actions as test CI #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jan 22, 2021

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Jan 16, 2021

Q A
Branch? "master"
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets comma-separated list of tickets fixed by the PR, if any
License MIT
Doc PR reference to the documentation PR, if any

Add PHP 8 compatibility and Use github actions as test CI.

See https://github.com/alexander-schranz/Testing/pull/1/checks

Requires:

@alexander-schranz alexander-schranz force-pushed the feature/add-gitlab-actions branch from 0ee09e8 to a43fad5 Compare January 16, 2021 11:38
@alexander-schranz alexander-schranz mentioned this pull request Jan 16, 2021
52 tasks
@alexander-schranz alexander-schranz force-pushed the feature/add-gitlab-actions branch 2 times, most recently from a6dd894 to e5c8e9c Compare January 16, 2021 18:38
Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, looks good - i checked the build output in your fork.

just one thing about the duplicated tests step

@alexander-schranz
Copy link
Contributor Author

Tests are green again: https://github.com/alexander-schranz/Testing/pull/1/checks. In the repository setting we would need to remove the Travis Integration Check in the branches settings when this is merged.

Copy link
Member

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prefer lowest is not working as intended. i suggest we use the same pattern you used in other MRs

@dbu
Copy link
Member

dbu commented Jan 22, 2021

now something with the lowest version build fails because of phpunit version. can we lock the phpunit bridge to a new version in composer.json?

@alexander-schranz
Copy link
Contributor Author

@dbu this did fix it. Thank you!

@dbu dbu merged commit 4182bac into symfony-cmf:master Jan 22, 2021
@dbu dbu mentioned this pull request Jan 22, 2021
@alexander-schranz alexander-schranz deleted the feature/add-gitlab-actions branch January 22, 2021 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants