-
Notifications
You must be signed in to change notification settings - Fork 20
Add PHP 8 compatibility and Use github actions as test CI #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PHP 8 compatibility and Use github actions as test CI #208
Conversation
0ee09e8
to
a43fad5
Compare
a6dd894
to
e5c8e9c
Compare
e5c8e9c
to
3f662b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, looks good - i checked the build output in your fork.
just one thing about the duplicated tests step
Co-authored-by: David Buchmann <[email protected]>
Tests are green again: https://github.com/alexander-schranz/Testing/pull/1/checks. In the repository setting we would need to remove the Travis Integration Check in the branches settings when this is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefer lowest is not working as intended. i suggest we use the same pattern you used in other MRs
now something with the lowest version build fails because of phpunit version. can we lock the phpunit bridge to a new version in composer.json? |
…ranz/Testing into feature/add-gitlab-actions
Add PHP 8 compatibility and Use github actions as test CI.
See https://github.com/alexander-schranz/Testing/pull/1/checks
Requires: