-
Notifications
You must be signed in to change notification settings - Fork 29
Added option to control the uuid-behavior #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
wachterjohannes
wants to merge
2
commits into
phpcr:master
from
wachterjohannes:enhancement/workspace-import-uuid-behavior
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -17,6 +17,13 @@ | |
*/ | ||
class WorkspaceImportCommand extends BaseCommand | ||
{ | ||
const UUID_BEHAVIOR = [ | ||
'new' => ImportUUIDBehaviorInterface::IMPORT_UUID_CREATE_NEW, | ||
'remove' => ImportUUIDBehaviorInterface::IMPORT_UUID_COLLISION_REMOVE_EXISTING, | ||
'replace' => ImportUUIDBehaviorInterface::IMPORT_UUID_COLLISION_REPLACE_EXISTING, | ||
'throw' => ImportUUIDBehaviorInterface::IMPORT_UUID_COLLISION_THROW, | ||
]; | ||
|
||
/** | ||
* {@inheritdoc} | ||
*/ | ||
|
@@ -28,6 +35,7 @@ protected function configure() | |
->setName('phpcr:workspace:import') | ||
->addArgument('filename', null, 'The xml file to import') | ||
->addOption('parentpath', 'p', InputOption::VALUE_OPTIONAL, 'Repository path to the parent where to import the file contents', '/') | ||
->addOption('uuid-behavior', null, InputOption::VALUE_REQUIRED, 'Behavior to handle uuid on import', 'new') | ||
->setDescription('Import xml data into the repository, either in JCR system view format or arbitrary xml') | ||
->setHelp(<<<'EOF' | ||
The <info>import</info> command uses the PHPCR SessionInterface::importXml method | ||
|
@@ -38,6 +46,15 @@ protected function configure() | |
|
||
If the <info>parentpath</info> option is set, the document is imported to that | ||
path. Otherwise the document is imported at the repository root. | ||
|
||
The optional <info>uuid-behavior</info> option describes how uuids should be | ||
handled. Following options are available: | ||
|
||
* <info>new</info> recreate the uuid foreach node | ||
* <info>remove</info> remove the node from imported dataset on uuid collision | ||
* <info>replace</info> replace the node in the database on uuid collision | ||
* <info>throw</info> throw exception on uuid collision | ||
|
||
EOF | ||
); | ||
} | ||
|
@@ -58,11 +75,15 @@ protected function execute(InputInterface $input, OutputInterface $output) | |
return 1; | ||
} | ||
|
||
$session->importXML( | ||
$parentPath, | ||
$filename, | ||
ImportUUIDBehaviorInterface::IMPORT_UUID_CREATE_NEW | ||
); | ||
$uuidBehavior = $input->getOption('uuid-behavior'); | ||
if (!array_key_exists($uuidBehavior, self::UUID_BEHAVIOR)) { | ||
$output->writeln(sprintf('<error>UUID-Behavior "%s" is not supported</error>', $uuidBehavior)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can we please add another line saying |
||
$output->writeln(sprintf('Supported behaviors are %s', implode(', ', array_keys(self::UUID_BEHAVIOR)))); | ||
|
||
return 1; | ||
} | ||
|
||
$session->importXML($parentPath, $filename, self::UUID_BEHAVIOR[$uuidBehavior]); | ||
$session->save(); | ||
|
||
$output->writeln(sprintf( | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just fyi: remove does remove the existing node on collision, not the one being imported, according to the jcr specification. i changed the doc accordingly.