Added option to control the uuid-behavior #184
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dbu what do you think? |
wachterjohannes
force-pushed
the
enhancement/workspace-import-uuid-behavior
branch
2 times, most recently
from
e437994 to
e481347
Compare
wachterjohannes
force-pushed
the
enhancement/workspace-import-uuid-behavior
branch
from
e481347 to
75110d2
Compare
dbu
reviewed
Feb 5, 2018
| ); | ||
| $uuidBehavior = $input->getOption('uuid-behavior'); | ||
| if (!array_key_exists($uuidBehavior, self::UUID_BEHAVIOR)) { | ||
| $output->writeln(sprintf('<error>UUID-Behavior "%s" is not supported</error>', $uuidBehavior)); |
There was a problem hiding this comment.
can we please add another line saying 'Supported behaviors are %s', implode(', ', self::UUID_BEHAVIOR)
|
@dbu what do you think? and are all of the description correct? |
|
i tweaked the wording a little bit and merged on the command line. tagged as 1.4.0, thanks a lot for the contribution! |
dbu
reviewed
Feb 6, 2018
| handled. Following options are available: | ||
|
|
||
| * <info>new</info> recreate the uuid foreach node | ||
| * <info>remove</info> remove the node from imported dataset on uuid collision |
There was a problem hiding this comment.
just fyi: remove does remove the existing node on collision, not the one being imported, according to the jcr specification. i changed the doc accordingly.
wachterjohannes
deleted the
enhancement/workspace-import-uuid-behavior
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an option to control the uuid-behavior on import. To avoid a BC-break the default is set to
IMPORT_UUID_CREATE_NEW.