Skip to content

Conversation

@javiereguiluz
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets -
Documentation -
License MIT

Similar to php-http/curl-client#82. This is needed to use this package in Symfony 7 applications.

@Chris53897
Copy link
Contributor

Could you please add a testrun for symfony 7?

@javiereguiluz
Copy link
Contributor Author

I've looked into https://github.com/php-http/client-common/blob/2.x/.github/workflows/tests.yml but I don't know where to put the tests for upcoming Symfony versions. You test "latest PHP", "lowest PHP" and "Symfony LTS".

@Chris53897
Copy link
Contributor

Chris53897 commented Nov 3, 2023

@dbu
Copy link
Contributor

dbu commented Nov 3, 2023

if phpspec is not moving quickly, i would be ok to merge this "blindly" and tag a patch version. the only component we use is options resolver, and that is really stable and no changes expected.

@Chris53897
Copy link
Contributor

@dbu Can you please have a look again, after symfony 7 is released today?

@dbu
Copy link
Contributor

dbu commented Nov 30, 2023

tagged as https://github.com/php-http/client-common/releases/tag/2.7.1

@Chris53897 if phpspec releases a new version, glad if you could do a pull request to run tests with symfony 7 ;-)

@Chris53897
Copy link
Contributor

Thanks. I did subscribed for releases on phpspec to get notified

@javiereguiluz javiereguiluz deleted the allow_sf7 branch November 30, 2023 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants