Skip to content

Conversation

@alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Nov 29, 2023

Requires another update:

@alexander-schranz
Copy link
Contributor Author

Not sure about the tests as they even fail on Symfony 6. @dbu do you have any idea they seems also failed last time on target branch: https://github.com/FriendsOfSymfony/FOSHttpCache/actions/runs/6640786360/job/18041892112

@dbu
Copy link
Contributor

dbu commented Nov 30, 2023

i am fixing the regression with the tests in #550

unfortunately i noticed that the RequestMatcher disappeared from symfony/http-foundation. we need to find a solution for that, did not yet investigate.

@alexander-schranz
Copy link
Contributor Author

alexander-schranz commented Nov 30, 2023

Looks like we need a bridge there between the 2 classes based on the Symfony Upgrade:

Remove RequestMatcher, use ChainRequestMatcher instead
Remove ExpressionRequestMatcher, use RequestMatcher\ExpressionRequestMatcher instead

but not sure how much compatible they are.

@dbu
Copy link
Contributor

dbu commented Nov 30, 2023

i think supporting both should be less difficult than i feared: #551

@dbu
Copy link
Contributor

dbu commented Nov 30, 2023

fixed it in the 2.x branch, can you please rebase?

@dbu
Copy link
Contributor

dbu commented Nov 30, 2023

the return type declarations would be a BC break if somebody overwrote the store method our trait defines.

the safe thing is to do a new major version of foshttpcache to add return types.

@dbu
Copy link
Contributor

dbu commented Dec 11, 2023

continuing in #552

@dbu dbu closed this Dec 11, 2023
@alexander-schranz alexander-schranz deleted the patch-1 branch February 9, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants