type declarations for php 7.1 #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
approved these changes
Jan 4, 2019
Member
Nyholm
left a comment
Nyholm
left a comment
There was a problem hiding this comment.
Thank you.
I just searched for places I could replace Foo $var = null with ?Foo $var. That's why I did not find these.
Member
|
This needs to be cased to an int. https://github.com/php-http/client-common/blob/master/src/Plugin/RedirectPlugin.php#L142 |
Contributor
Author
|
the problem are us mocking the response in a way that violates response interface. the status code must be an int according to the interface. |
GrahamCampbell
approved these changes
Jan 4, 2019
Contributor
GrahamCampbell
left a comment
GrahamCampbell
left a comment
There was a problem hiding this comment.
Looks good (probably needs adding to the v2.0.0 milestone though)
Member
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some more strict types where we can. the
: voidis useful for tools that report when the return value of a void method is being used.