type declarations for php 7.1

Author: dbu

src/Deferred.php

@@ -79,7 +79,7 @@ public function getState(): string
     /**
      * Resolve this deferred with a Response.
      */
-    public function resolve(ResponseInterface $response)
+    public function resolve(ResponseInterface $response): void
     {
         if (self::PENDING !== $this->state) {
             return;
@@ -96,7 +96,7 @@ public function resolve(ResponseInterface $response)
     /**
      * Reject this deferred with an Exception.
      */
-    public function reject(Exception $exception)
+    public function reject(Exception $exception): void
     {
         if (self::PENDING !== $this->state) {
             return;

src/Exception/BatchException.php

@@ -28,10 +28,8 @@ public function __construct(BatchResult $result)
 
     /**
      * Returns the BatchResult that contains all responses and exceptions.
-     *
-     * @return BatchResult
      */
-    public function getResult()
+    public function getResult(): BatchResult
     {
         return $this->result;
     }

src/HttpClientPool/HttpClientPool.php

@@ -27,7 +27,7 @@ abstract class HttpClientPool implements HttpClientPoolInterface
      *
      * @param ClientInterface|HttpAsyncClient|HttpClientPoolItem $client
      */
-    public function addHttpClient($client)
+    public function addHttpClient($client): void
     {
         if (!$client instanceof HttpClientPoolItem) {
             $client = new HttpClientPoolItem($client);

src/HttpClientPool/HttpClientPoolItem.php

@@ -144,31 +144,31 @@ public function getSendingRequestCount(): int
     /**
      * Increment the request count.
      */
-    private function incrementRequestCount()
+    private function incrementRequestCount(): void
     {
         ++$this->sendingRequestCount;
     }
 
     /**
      * Decrement the request count.
      */
-    private function decrementRequestCount()
+    private function decrementRequestCount(): void
     {
         --$this->sendingRequestCount;
     }
 
     /**
      * Enable the current client.
      */
-    private function enable()
+    private function enable(): void
     {
         $this->disabledAt = null;
     }
 
     /**
      * Disable the current client.
      */
-    private function disable()
+    private function disable(): void
     {
         $this->disabledAt = new \DateTime('now');
     }

src/HttpClientRouter.php

@@ -45,7 +45,7 @@ public function sendAsyncRequest(RequestInterface $request)
      *
      * @param HttpClient|HttpAsyncClient $client
      */
-    public function addClient($client, RequestMatcher $requestMatcher)
+    public function addClient($client, RequestMatcher $requestMatcher): void
     {
         $this->clients[] = [
             'matcher' => $requestMatcher,

src/HttpClientRouterInterface.php

@@ -23,5 +23,5 @@ interface HttpClientRouterInterface extends HttpClient, HttpAsyncClient
      *
      * @param ClientInterface|HttpAsyncClient $client
      */
-    public function addClient($client, RequestMatcher $requestMatcher);
+    public function addClient($client, RequestMatcher $requestMatcher): void;
 }

src/HttpMethodsClient.php

@@ -71,7 +71,7 @@ public function options($uri, array $headers = [], $body = null): ResponseInterf
         return $this->send('OPTIONS', $uri, $headers, $body);
     }
 
-    public function send($method, $uri, array $headers = [], $body = null): ResponseInterface
+    public function send(string $method, $uri, array $headers = [], $body = null): ResponseInterface
     {
         return $this->sendRequest($this->requestFactory->createRequest(
             $method,

src/HttpMethodsClientInterface.php

@@ -112,5 +112,5 @@ public function options($uri, array $headers = [], $body = null): ResponseInterf
      *
      * @throws Exception
      */
-    public function send($method, $uri, array $headers = [], $body = null): ResponseInterface;
+    public function send(string $method, $uri, array $headers = [], $body = null): ResponseInterface;
 }

src/Plugin/AddHostPlugin.php

@@ -66,7 +66,7 @@ public function handleRequest(RequestInterface $request, callable $next, callabl
         return $next($request);
     }
 
-    private function configureOptions(OptionsResolver $resolver)
+    private function configureOptions(OptionsResolver $resolver): void
     {
         $resolver->setDefaults([
             'replace' => false,

src/Plugin/CookiePlugin.php

@@ -91,11 +91,9 @@ public function handleRequest(RequestInterface $request, callable $next, callabl
     /**
      * Creates a cookie from a string.
      *
-     * @return Cookie|null
-     *
      * @throws TransferException
      */
-    private function createCookie(RequestInterface $request, string $setCookieHeader)
+    private function createCookie(RequestInterface $request, string $setCookieHeader): ?Cookie
     {
         $parts = array_map('trim', explode(';', $setCookieHeader));
 
@@ -168,6 +166,8 @@ private function createCookie(RequestInterface $request, string $setCookieHeader
      * Separates key/value pair from cookie.
      *
      * @param string $part A single cookie value in format key=value
+     *
+     * @return string[]
      */
     private function createValueKey(string $part): array
     {