Skip to content

cache_lifetime must be an integer or null #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 1, 2022
Merged

cache_lifetime must be an integer or null #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c734318
cache_lifetime must be an integer or null
VirgileZol May 31, 2022
b70c8b1
Update Configuration.php
VirgileZol May 31, 2022
fd31b3e
Update Configuration.php
VirgileZol May 31, 2022
7806320
Update CHANGELOG.md
VirgileZol May 31, 2022
4429ec9
Update CHANGELOG.md
dbu Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@

The change log describes what is "Added", "Removed", "Changed" or "Fixed" between each release.

# 1.xx.yy- YYYY-MM-JJ

- Fixed: You can now configure the cache plugin option `cache_lifetime` to `null` (which makes the plugin not add to the maxAge).

# 1.26.1 - 2022-04-29

- Fixed: Setting the cache plugin option `respect_response_cache_directives` to `null` makes the
Expand Down
8 changes: 7 additions & 1 deletion src/DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,8 +710,14 @@ private function createCachePluginNode()
->scalarNode('cache_key_generator')
->info('This must be a service id to a service implementing '.CacheKeyGenerator::class)
->end()
->integerNode('cache_lifetime')
->scalarNode('cache_lifetime')
->info('The minimum time we should store a cache item')
->validate()
->ifTrue(function ($v) {
return null !== $v && !is_int($v);
})
->thenInvalid('cache_lifetime must be an integer or null, got %s')
->end()
->end()
->scalarNode('default_ttl')
->info('The default max age of a Response')
Expand Down