cache_lifetime must be an integer or null #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
reviewed
Jun 1, 2022
There was a problem hiding this comment.
thanks for the contribution, indeed null is an accepted value in the plugin.
i realize that the respect_response_cache_directives null is somehow inconsistent with the other options - for those where the plugin accepts null as option, we forward the null, which is different from the default value. according to https://github.com/php-http/cache-plugin/blob/master/src/CachePlugin.php#L233 we treat null as 0 for the cache_lifetime option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Fix
Invalid type for path "httplug.clients.xxx.plugins.xxx.cache.config.cache_lifetime". Expected "int", but got "null".
cache_lifetime must be an integer or null
Example Usage
Checklist