Skip to content

Fixes #100. Incorrect instance of item passed to addTags method. #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2017
Merged

Fixes #100. Incorrect instance of item passed to addTags method. #66

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/Cache/FixedTaggingCachePool.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,9 @@ public function deleteItems(array $keys)
*/
public function save(CacheItemInterface $item)
{
$this->addTags($item);
if ($item instanceof TaggableItemInterface) {
Copy link
Member

@Nyholm Nyholm Mar 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TaggableItemInterface is deprecated. We should move towards TaggableCacheItemInterface.

I will merge this and the look over the bundles to see what changes we need to do for the latest version of tags.

$this->addTags($item);
}

return $this->cache->save($item);
}
Expand Down