Fixes #100. Incorrect instance of item passed to addTags method. #66
+3
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
==========================================
- Coverage 24.75% 24.69% -0.07%
==========================================
Files 21 21
Lines 808 810 +2
==========================================
Hits 200 200
- Misses 608 610 +2
Continue to review full report at Codecov.
|
Nyholm
reviewed
Mar 26, 2017
| public function save(CacheItemInterface $item) | ||
| { | ||
| $this->addTags($item); | ||
| if ($item instanceof TaggableItemInterface) { |
Member
There was a problem hiding this comment.
TaggableItemInterface is deprecated. We should move towards TaggableCacheItemInterface.
I will merge this and the look over the bundles to see what changes we need to do for the latest version of tags.
Member
|
Thank you for this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes php-cache/issues#100.