Skip to content

Conversation

@sGerli
Copy link
Member

@sGerli sGerli commented May 21, 2019

Fix for #54

@sGerli
Copy link
Member Author

sGerli commented May 21, 2019

Blog page index: /blog
Blog page full URL /blog/:page
Pagination preview:
image

I think this PR is done. But I wouldn't merge until the new home screen is live because the home page and the blog index are the same.

@sGerli sGerli changed the title WIP: Dev/display old posts Display old posts by adding blog with pagination May 21, 2019
@sGerli sGerli requested a review from ishotjr May 21, 2019 20:09
@ishotjr ishotjr self-assigned this May 22, 2019
Copy link
Member

@ishotjr ishotjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent - thank you so much! Would it be possible to split it into two parts though - add pagination to home now to close this issue, and then move everything to /blog separately in support of #56 ? In addition to the redundancy that you mentioned, adding blog to the nav causes it to wrap, which is something we can deal with later - but just adding the pagination to / would be a huge win that we can roll out immediately! 😍

@sGerli
Copy link
Member Author

sGerli commented May 22, 2019

I tried but it seems like Jekyll pagination (at least the method I'm trying) doesn't work on root /.

@ishotjr ishotjr mentioned this pull request May 26, 2019
@sGerli sGerli mentioned this pull request May 26, 2019
@sGerli
Copy link
Member Author

sGerli commented May 26, 2019

Superseded by #59

@sGerli sGerli closed this May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants