Skip to content

Conversation

@sGerli
Copy link
Member

@sGerli sGerli commented May 26, 2019

Includes:

  • New home page
  • New blog page with pagination
  • Moved css to scss
  • Added excerpts to the last posts
  • Fixed navigation wrapping issues

Supersedes #57 and #58

_data/home.yml Outdated
@@ -0,0 +1,2 @@
heading: Bring life back to your Pebble
about: Lorem ipsum dolor sit amet, consectetur adipiscing elit. Suspendisse vehicula, purus vitae vulputate varius, ipsum orci maximus erat, nec tempor massa purus id purus. Nullam ligula augue, ultricies id sollicitudin quis, dictum sit amet leo. No newline at end of file
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dummy text still needs to be changed.

@ishotjr ishotjr self-assigned this May 31, 2019
Copy link
Member

@ishotjr ishotjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work - thank you so much for this! 😍 Couple of tweaks/issues - can't wait to see this go live! :bowtie: 💭 🚀

@@ -0,0 +1,61 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for some reason I get a 404 for /blog when I test the site locally; it worked fine for me in #57 - is it working for you? 🔎 🗿

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's weird, it's working for me.

image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishotjr can you check that you're on the right branch?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sGerli ah - totally failed to notice we'd moved to home-plus-blog - thanks!! 🤦‍♂

Copy link
Member

@ishotjr ishotjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 ❣️ 🚀 ❣️ 🚀

@ishotjr ishotjr merged commit 4df6e90 into pebble-dev:master May 31, 2019
@ishotjr ishotjr mentioned this pull request May 31, 2019
@ishotjr
Copy link
Member

ishotjr commented May 31, 2019

@sGerli FYI had to force CSS to refresh for summary styling to display correctly in my browser ... 🤔 ❤️

@sGerli
Copy link
Member Author

sGerli commented May 31, 2019

Yeah, I noticed that. To force all browsers to update we would have needed to modify the css import with a query string like ?version=1.2.0.

@ishotjr
Copy link
Member

ishotjr commented May 31, 2019

@sGerli yep, let's version it in future! 👍

@sGerli
Copy link
Member Author

sGerli commented May 31, 2019

In other news: This PR fixes the navbar urls so now you should be able to tick the Enforce HTTPS checkbox in the settings to fully move to https.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants