-
Notifications
You must be signed in to change notification settings - Fork 0
doc: clean examples and add jax-fem #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9 +/- ##
=======================================
Coverage 95.78% 95.78%
=======================================
Files 3 3
Lines 190 190
Branches 22 22
=======================================
Hits 182 182
Misses 5 5
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Is there any chance you could break down this PR? It is already 3k LoC, and according to checkmarks will grow further. Reviewing such a big PR is not an easy task at all! In fact, i think most of these checkboxes, except the first maybe, can be their own separate PR. Would be really great to make it more sizeable! |
|
@apaleyes Totally agree about each checkbox being worthy of its own PR, sorry! There were a few things which came up while I was adding the JAX-FEM example (which was the whole reason for this branch), so it felt natural to patch them as I went, but that was laziness.
I think this may be from the autogenerated dependency management. If you ignore the You're right, though. Sorry for the bloated PR. Happy to try splitting this up, although all the work is done now (the checkboxes were left unchecked mainly because I wanted to test). |
|
We have failing tests, documentation build issues, and code linting issues, so I will definitely split this after all to avoid more bloat. |
|
thanks @jacanchaplais ! i know this is not the most pleasant process |
|
No, it's good, I appreciate the quality control! |
Relevant issue or PR
Closes #4.
Description of changes
examples/tesseract-jaxstpyvistarender too zoomed in, going blank if user rotatespanelbackend withtrameTesting done