Skip to content

Conversation

@jacanchaplais
Copy link
Collaborator

@jacanchaplais jacanchaplais commented Jul 4, 2025

Relevant issue or PR

Closes #4.

Description of changes

  • Create nested directory structure for examples/
  • Add JAX-FEM example based on tesseract-jax
  • Fix stpyvista render too zoomed in, going blank if user rotates
    • Replaced panel backend with trame
  • Add examples section to readthedocs
  • Fix JSON pretty printing in Streamlit app for outputs with arrays of dimension 0
  • Fix Streamlit number field not displaying numbers with magnitude much less than one

Testing done

@jacanchaplais jacanchaplais self-assigned this Jul 4, 2025
@jacanchaplais jacanchaplais added the bug Something isn't working label Jul 4, 2025
@jacanchaplais jacanchaplais added the documentation Improvements or additions to documentation label Jul 4, 2025
@codecov
Copy link

codecov bot commented Jul 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.78%. Comparing base (da625e0) to head (224f589).

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files           3        3           
  Lines         190      190           
  Branches       22       22           
=======================================
  Hits          182      182           
  Misses          5        5           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@apaleyes
Copy link
Contributor

apaleyes commented Jul 4, 2025

Is there any chance you could break down this PR? It is already 3k LoC, and according to checkmarks will grow further. Reviewing such a big PR is not an easy task at all!

In fact, i think most of these checkboxes, except the first maybe, can be their own separate PR. Would be really great to make it more sizeable!

@jacanchaplais
Copy link
Collaborator Author

jacanchaplais commented Jul 4, 2025

@apaleyes Totally agree about each checkbox being worthy of its own PR, sorry! There were a few things which came up while I was adding the JAX-FEM example (which was the whole reason for this branch), so it felt natural to patch them as I went, but that was laziness.

It is already 3k LoC, and according to checkmarks will grow further.

I think this may be from the autogenerated dependency management. If you ignore the uv.lock / other dependency files, and the fact that I've changed the name of a directory (so it's logging a lot more diffs than there are), this PR is a lot smaller.

You're right, though. Sorry for the bloated PR. Happy to try splitting this up, although all the work is done now (the checkboxes were left unchecked mainly because I wanted to test).

@jacanchaplais
Copy link
Collaborator Author

We have failing tests, documentation build issues, and code linting issues, so I will definitely split this after all to avoid more bloat.

@apaleyes
Copy link
Contributor

apaleyes commented Jul 4, 2025

thanks @jacanchaplais ! i know this is not the most pleasant process

@jacanchaplais
Copy link
Collaborator Author

No, it's good, I appreciate the quality control!

@jacanchaplais jacanchaplais mentioned this pull request Jul 7, 2025
6 tasks
@pasteurlabs pasteurlabs locked and limited conversation to collaborators Jul 7, 2025
@jacanchaplais jacanchaplais deleted the jacan/examples branch July 8, 2025 10:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Tesseract-JAX FEM optimisation example

2 participants