-
Notifications
You must be signed in to change notification settings - Fork 0
doc: add jax-fem example #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
=======================================
Coverage 94.95% 94.95%
=======================================
Files 4 4
Lines 218 218
Branches 25 25
=======================================
Hits 207 207
Misses 8 8
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@apaleyes I think the massive diff is sort of unavoidable because of |
Co-authored-by: Dion Häfner <[email protected]>
CLA signatures confirmedAll contributors have signed the Contributor License Agreement. |
@PasteurBot I have read the CLA Document and I hereby sign the CLA |
@PasteurBot I have read the CLA Document and I hereby sign the CLA |
what am I missing here? 🫠 |
#### Relevant issue or PR <!-- If the changes resolve an issue or follow some other PR, link to them here. GitHub references are strongly preferred, but links to other resources, such as Jira or Confluence, can also be used. Only link something if it is directly relevant. --> Cherry picked from #9. #### Description of changes <!-- Add a high-level description of changes, focusing on the *what* and *why*. --> Adds examples section to Sphinx generated ReadTheDocs. Won't work until #12 is merged, since it relies on the new directory structure in the `examples/` folder. #### Testing done <!-- Describe how the changes were tested; e.g., "CI passes", "Tested manually in stagingrepo#123", screenshots of a terminal session that verify the changes, or any other evidence of testing the changes. -->
…act-streamlit into jacan/example-jax-fem
@jacanchaplais @NolanBlack just wondering if this PR is done and just waiting for a review, before diving into said review. Any clues? |
Hi @apaleyes! The data generation part is done, but the visualisation still needs to be performed. Not being an CAD / engineering guy, I don't know what a meaningful visual of the data would be. @dionhaefner mentioned he may assign himself the task for fun, but either way we'll need somebody to take the von Mises stress and come up with a nice PyVista visual for it to merge this PR. |
Relevant issue or PR
Closes #4.
Description of changes
vectoradd_jax
example to a subdirectory ofexamples/
vectoradd_jax
jax_fem
example, with README, run script, and example JSON input for bar parametersSuggested by @dionhaefner
bar_params
auto-populatedTesting done
None yet. Will need to test, since this is an extract of #9, and bits may be missing.