Skip to content

Conversation

jacanchaplais
Copy link
Collaborator

Relevant issue or PR

Cherry-picked from #9.

Description of changes

Switches the backend for PyVista to trame instead of panel. This was necessary as panel appears to render the visualisations zoomed in, and would break depending on which form of interaction (panning, zooming, rotating) first occurred on the visualisation. The trame backend does not have these issues.

This should be merged after #13.

Testing done

@codecov
Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.78%. Comparing base (b7cfedd) to head (6133d51).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   95.78%   95.78%           
=======================================
  Files           3        3           
  Lines         190      190           
  Branches       22       22           
=======================================
  Hits          182      182           
  Misses          5        5           
  Partials        3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jacanchaplais jacanchaplais self-assigned this Jul 7, 2025
@jacanchaplais jacanchaplais changed the title Jacan/pyvista backend fix: use trame backend for stpyvista Jul 7, 2025
@jacanchaplais jacanchaplais added the bug Something isn't working label Jul 7, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those changes related to the trame backend?

Copy link
Collaborator Author

@jacanchaplais jacanchaplais Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but they got merged in from the cherry pick on #9. That's why this should be merged after #13. (it will be in the history of main after #13 is merged)

@jacanchaplais
Copy link
Collaborator Author

Going to remove the accidental pollution from #13. Closing.

@jacanchaplais jacanchaplais deleted the jacan/pyvista-backend branch July 8, 2025 15:03
@pasteurlabs pasteurlabs locked and limited conversation to collaborators Jul 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants