Skip to content

fix: run fields_mismatch against static_schema data also #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 23, 2025
+1 −5
Merged

fix: run fields_mismatch against static_schema data also #1123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0aa4fd8
fix: run `fields_mismatch` against `static_schema` data also
Jan 20, 2025
f2f8e05
chore: remove unused param
Jan 20, 2025
e58f361
Merge branch 'main' into fix-static
Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/event/format/json.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ impl EventFormat for Event {
fn to_data(
self,
schema: &HashMap<String, Arc<Field>>,
static_schema_flag: bool,
time_partition: Option<&String>,
schema_version: SchemaVersion,
) -> Result<(Self::Data, Vec<Arc<Field>>, bool), anyhow::Error> {
Expand Down Expand Up @@ -94,8 +93,7 @@ impl EventFormat for Event {
}
};

if !static_schema_flag
&& value_arr
if value_arr
.iter()
.any(|value| fields_mismatch(&schema, value, schema_version))
{
Expand Down
2 changes: 0 additions & 2 deletions src/event/format/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@ pub trait EventFormat: Sized {
fn to_data(
self,
schema: &HashMap<String, Arc<Field>>,
static_schema_flag: bool,
time_partition: Option<&String>,
schema_version: SchemaVersion,
) -> Result<(Self::Data, EventSchema, bool), AnyError>;
Expand All @@ -97,7 +96,6 @@ pub trait EventFormat: Sized {
) -> Result<(RecordBatch, bool), AnyError> {
let (data, mut schema, is_first) = self.to_data(
storage_schema,
static_schema_flag,
time_partition,
schema_version,
)?;
Expand Down
Loading