Skip to content

Conversation

@de-sh
Copy link
Contributor

@de-sh de-sh commented Jan 20, 2025

Fixes #XXXX.

Description

Don't cast floats as int on streams with static_schema_flag set


Testing Methodology

  1. Start parseable.
  2. Create new static schema stream with an int field.
  3. Push data on the static schema stream with float value.

Without the fix, value is being rounded out, which is wrong as we lose data.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@coveralls
Copy link

coveralls commented Jan 20, 2025

Pull Request Test Coverage Report for Build 12874465279

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 12.7%

Totals Coverage Status
Change from base Build 12873819985: -0.01%
Covered Lines: 2456
Relevant Lines: 19338

💛 - Coveralls

Copy link
Contributor

@nikhilsinhaparseable nikhilsinhaparseable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nitisht nitisht merged commit 5286782 into parseablehq:main Jan 23, 2025
11 checks passed
@de-sh de-sh deleted the fix-static branch January 23, 2025 05:08
@de-sh de-sh restored the fix-static branch January 23, 2025 05:08
@de-sh de-sh deleted the fix-static branch February 16, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants