Skip to content

Conversation

@dblythy
Copy link
Member

@dblythy dblythy commented Jun 7, 2023

Pull Request

Issue

Closes: #8592

Approach

Tasks

  • Add tests
  • Add changes to documentation (guides, repository pages, code comments)
  • Add security check
  • Add new Parse Error codes to Parse JS SDK

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: update ldap feat: Update ldap Jun 7, 2023
@parse-github-assistant
Copy link

Thanks for opening this pull request!

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (e2e51d9) 94.43% compared to head (6af5371) 94.42%.

❗ Current head 6af5371 differs from pull request most recent head f2965e7. Consider uploading reports for the commit f2965e7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8623      +/-   ##
==========================================
- Coverage   94.43%   94.42%   -0.01%     
==========================================
  Files         184      184              
  Lines       14613    14613              
==========================================
- Hits        13800    13799       -1     
- Misses        813      814       +1     
Impacted Files Coverage Δ
src/Adapters/Auth/ldap.js 94.23% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dblythy
Copy link
Member Author

dblythy commented Jun 9, 2023

It seems that this update isn't compatible with Node 14

@mtrezza
Copy link
Member

mtrezza commented Jun 9, 2023

Thanks, well merge the PR in 6 4 month then, when we prepare the Parse Server 7 release that drops Node 14 support.

@dblythy dblythy added the state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message label Jun 11, 2023
@suathh
Copy link

suathh commented Dec 28, 2023

Hey, @dblythy , we plan to release this update in version 7, but there is currently a conflict with this PR. Can you please take a look to resolve that?

@mtrezza
Copy link
Member

mtrezza commented Feb 26, 2024

Closing via #8947

@mtrezza mtrezza closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:breaking Breaking change requires major version increment and `BREAKING CHANGE` commit message

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants