refactor: Upgrade ldapjs from 2.3.3 to 3.0.2 #8592
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically created by Snyk using the credentials of a real user.
Snyk has created this PR to upgrade ldapjs from 2.3.3 to 3.0.2.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
Warning: This is a major version upgrade, and may be a breaking change.
Release notes
Package name: ldapjs
-
3.0.2 - 2023-03-28
- build(deps-dev): bump eslint from 8.35.0 to 8.36.0 by @ dependabot in #851
- build(deps): bump @ ldapjs/messages from 1.0.1 to 1.0.2 by @ dependabot in #852
- Add test for issue 860 by @ jsumners in #861
- transcontextual safe type checks by @ axkibe in #864
- @ axkibe made their first contribution in #864
-
3.0.1 - 2023-03-08
- build(deps-dev): bump eslint from 8.34.0 to 8.35.0 by @ dependabot in #844
- Quick fix for outdated client doc still referring to result.object by @ Tethik in #846
- Resolve issue #845 by @ jsumners in #847
- Add Node.js version support to readme by @ jsumners in #848
-
3.0.0 - 2023-02-22
- Common modules have been broken out into separate installable modules:
- Change objects: generic JavaScript objects are no longer supported as
- Message objects no longer have a
- Filter strings no longer provide a static exception on case sensitive comparisons for
-
2.3.3 - 2022-06-08
from ldapjs GitHub release notesWhat's Changed
New Contributors
Full Changelog: v3.0.1...v3.0.2
What's Changed
Full Changelog: v3.0.0...v3.0.1
🎉🎉🎉 Version 3.0.0 Is Here
This release has been in development for many months. The first commit toward this goal happened on 2019-09-01, but work really started with a commit on 2022-03-27.
This is not a trivial release. There are significant changes under the hood. They include:
@ ldapjs/attribute-- a comprehensive implementation of the LDAPattributespec.@ ldapjs/change-- a full implementation of RFC 4511 §4.6.@ ldapjs/controls-- specific implementations for all supported controls (with a caveat detailed below) that inherit from a base identifiable object.@ ldapjs/dn-- providesDNandRDNobjects to represent LDAP distinguished names.@ ldapjs/messages-- all supported messages as their own objects with methods and properties matching the specs, including a complete overhaul of theextension(renamed fromextended) request and response objects (with added support for several extensions, e.g. "password modify").@ ldapjs/protocol-- now with a full suite of operation identifiers, result codes, and search tags.ldap-filterhas been forked to@ ldapjs/filter. It includes improvements around value escaping, modern method signatures, and identifiable "class" objects. The full set of changes can be reviewed at ldapjs/filter@daa5a5d...v2.0.0asn1has been forked to@ ldapjs/asn1. Methods have been improved, e.g.BerReader.readBooleannow accepts a tag to expect, new ones added, e.g.BerWriter.appendBuffer, unreachable code removed, and bugs fixed. The full set of changes can be reviewed at ldapjs/asn1@bf1bb90...v2.0.0Additionally, all of the above modules now have complete, 100%, test coverage (except for
@ ldapjs/filter; PRs are welcome to help out here). They are also comprehensively documented with jsdoc.We expect there are going to be issues with this release. We worked hard to make sure all of the current tests pass without any changes (or at least none that affect the purpose of the test). But the current test suite is by no means comprehensive, and such sweeping changes as are present in this release are almost guaranteed to introduce new bugs. Please bear with us as we resolve them. Your contributions to fix any such bugs will help greatly.
Even the simple act of opening an issue describing something you've found that should be in these release notes would be a big help. For example, if you have determined that a change in some object API, e.g. the
SearchRequestobject, should be highlighted, then please open an issue describing the change so that we can add an it to an addendum on these release notes.The Biggest Change
We think that the most impactful change is going to be the decoupling of the underlying byte arrays from all objects. In v2 and earlier, the client, server, controls, messages, and everything else passed around single byte arrays during the handling of requests. The benefit of this is reduced memory consumption and faster handling of requests. The downside is an extremely difficult to understand and maintain codebase. As part of the work to modularize this codebase, we opted to make byte array processing idempotent in the majority of cases. This will have an impact on performance, but we do not know how much of an impact. We do not have any way to benchmark the before and after of this change. We suspect (hope) that in the majority of cases it will not be noticeable.
VLV Controls
During the development of v3 we were not clear if the VLV implementation that was added to v2 was correct. So we opted to cut it for the release. Shortly after cutting it, we determined that the implementation is very likely correct. You can read about this decision at #797 (comment) and the realization at #797 (comment).
Ultimately, we decided to postpone adding this feature back so that we could get v3 shipped.
Conclusion
A lot of hard work has gone into this release. We think it lays the ground work for a much more maintainable codebase. We envision being able to re-implement the server and client components as
@ ldapjs/serverand@ ldapjs/clientat some point in the future. We think there is a real opportunity to refactor both components into more modern interfaces with significant improvements (particularly in the form of error handling). No promises are made about when such projects might be undertaken, if ever. But they wouldn't be possible without the work in this v3 release.In regard to my (James Sumners) personal contributions to this release, please consider using my ❤️ GitHub Sponsor link to show your gratitude. Contributions will be particularly helpful at this time; I was laid off as part of a significant downsizing event at my previous employer and am currently unemployed.
Additionally, a big thank you to @ dirmgr for his willingness to answer general LDAP protocol questions and the abundance of well written documentation he has provided at https://nawilson.com/ldapv3-wire-protocol-reference/ and https://ldap.com/learn-about-ldap/. The help and articles were indispensable in crafting this release.
Known Breaking Changes
Client
options.strictDN: removed. All DN parsing is now "strict". It does not make any sense to try and parse DN strings that are not spec compliant..modify: no longer accepts plain objects as change descriptors. An instance of@ ldapjs/changeis now required.searchEntryobject: thesearchEntryobject no longe provides a.rawproperty. The access this property provided is now supplied by thesearchEntryobject's standard methods and accessors, e.g..attributesfor the set of attributes returned on the entry. Further, accessing binary field values should be done by specifying the;binaryattribute option as per the LDAP spec. See #850 and #858 for more detail.changeobjects. When creating a newchangeobject,@ ldapjs/attributeobjects must be provided (or a plain object that conforms to anattributeobject). See #859 for more detail.Server
options.strictDN: removed. All DN parsing is now "strict". It does not make any sense to try and parse DN strings that are not spec compliant..listen: No longer listens on0.0.0.0when nohostparameter is provided. It now uses the secure default of127.0.0.1..search: the results ofSearchRequest.scopechanged to the spec defined search scope names. With[email protected](and@ ldapjs/[email protected]) you must match againstbase,single, andsubtreeinstead ofbase,one, andsub. This has been corrected in[email protected](with@ ldapjs/[email protected]) via PR #847. See the unit test included in that release for the recommended approach for matching search scopes.General
.objectaccessor. This has been replaced with the.pojoaccessor. It didn't make any sense to have a message object with an accessor that returns an object (it's confusing). The.pojoaccessor states what will be returned: a plain JavaScript object. You may find that the actual message object now has fields you can directly use. See #841.objectClass. Inldapjs@2and earlier, there were many explicit checks forobjectClassbeing compared. When such a comparison was found, the code always performed that specific comparison in a case insensitive manner. As ofldapjs@3, you must specify that you want to perform case insensitive comparisons on property names. See ldapjs/filter#3 for more detail.Read more
Commit messages
Package name: ldapjs
Compare
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.
For more information:
🧐 View latest project report
🛠 Adjust upgrade PR settings
🔕 Ignore this dependency or unsubscribe from future upgrade PRs