Skip to content

Rewriting method createClass #4467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Rewriting method createClass #4467

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8bf618b
Rewriting method createClass
vitaly-t Dec 28, 2017
eb314a0
Merge branch 'master' into vitaly-t-patch-1
vitaly-t Dec 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 24 additions & 15 deletions src/Adapters/Storage/Postgres/PostgresStorageAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -662,24 +662,33 @@ export class PostgresStorageAdapter {

createClass(className, schema, conn) {
conn = conn || this._client;
return conn.tx('create-class', t => {
const q1 = this.createTable(className, schema, t);
const q2 = t.none('INSERT INTO "_SCHEMA" ("className", "schema", "isParseClass") VALUES ($<className>, $<schema>, true)', { className, schema });
const q3 = this.setIndexesWithSchemaFormat(className, schema.indexes, {}, schema.fields, t);
return t.batch([q1, q2, q3]);
})
.then(() => {
return toParseSchema(schema);
})
.catch(err => {
if (err.data[0].result.code === PostgresTransactionAbortedError) {
err = err.data[1].result;
const self = this;

return conn.tx('create-class', function * (t) {
let error;
try {
yield self.createTable(className, schema, t);
} catch(e) {
if (e.code === PostgresTransactionAbortedError) {
error = e;
}
if (err.code === PostgresUniqueIndexViolationError && err.detail.includes(className)) {
}
try {
yield t.none('INSERT INTO "_SCHEMA" ("className", "schema", "isParseClass") VALUES ($<className>, $<schema>, true)', { className, schema });
} catch(e) {
error = e;
}
if (error) {
if (error.code === PostgresUniqueIndexViolationError && error.detail.includes(className)) {
throw new Parse.Error(Parse.Error.DUPLICATE_VALUE, `Class ${className} already exists.`)
}
throw err;
})
throw error;
}
yield self.setIndexesWithSchemaFormat(className, schema.indexes, {}, schema.fields, t);
})
.then(() => {
return toParseSchema(schema);
});
}

// Just create a table, do not insert in schema
Expand Down