Rewriting method createClass #4467
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So it would make sense in how queries are handled, how their results are handled and how errors are processed. It was originally a bit of a logical mess, also using results / error handling that wasn't clear, and not always reliable.
Codecov Report
@@ Coverage Diff @@
## master #4467 +/- ##
=========================================
Coverage ? 92.75%
=========================================
Files ? 118
Lines ? 8360
Branches ? 0
=========================================
Hits ? 7754
Misses ? 606
Partials ? 0
Continue to review full report at Codecov.
|
Contributor
Author
|
Neya, that's it, I'm bailing on this 💩 |
This was referenced Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...so it would make sense in how queries are handled, how their results are handled and how errors are processed.
It was originally a bit of a logical mess, also using results / error handling that wasn't clear, and not always reliable.
P.S. Looks like it still needs some work, call it work-in-progress ;)