Fixed wrong usage of contentAvailable for iOS push notifications via Firebase #165
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funkenstrahlen
approved these changes
Aug 25, 2020
Contributor
funkenstrahlen
left a comment
funkenstrahlen
left a comment
There was a problem hiding this comment.
Looks Good to me.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that it is not possible to send notifications to iOS devices due to not being able to pass the correct option to node-gcm. I fixed this wrong string. I tested it, it works great. For typescript the types need to be updated I'll also do it as soon as this is merged
This fixes #164
https://github.com/ToothlessGear/node-gcm