This repository was archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
chore: add example for balance AccountStore #10361
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
deff306
chore: modified example for balance AccountStore
ECJ222 3f1f781
Merge branch 'paritytech:master' into master
ECJ222 9af280d
Merge branch 'paritytech:master' into master
ECJ222 2bde14d
add example for account store balance
ECJ222 f5f8e73
Merge branch 'master' of https://github.com/ECJ222/substrate
ECJ222 a6cf727
add example for account store balance
ECJ222 1314ccb
Update frame/balances/src/lib.rs
bkchr f351552
Update frame/balances/src/lib.rs
bkchr e5baae4
Merge branch 'paritytech:master' into master
ECJ222 6a5a678
Merge branch 'paritytech:master' into master
ECJ222 92181cf
balance account store example
ECJ222 64ddda6
balance account store example
ECJ222 d491476
Update frame/balances/src/lib.rs
kianenigma 4970679
Update frame/balances/src/lib.rs
kianenigma 3f71ad7
balance account store example
ECJ222 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some docs on what this does would be nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ECJ222 this is still not done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please could you explain a little bit more on this, can I put the explanation above the updated code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry but doc still is not really sensible. You should explain the context, what options are available (store the data in this pallet or in system), which one is better, what tradeoff exists etc.
I really don't see any value in adding this one example block.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made an update to my initial pr @kianenigma