This repository was archived by the owner on Nov 15, 2023. It is now read-only.
chore: add example for balance AccountStore #10361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ECJ222
changed the title
bkchr
reviewed
Nov 24, 2021
| /// | ||
| /// ``` | ||
| /// impl Balance for Runtime { | ||
| /// type AccountStore = StorageMapShim<Self::Account<Runtime>, frame_system::Provider<Runtime>, AccountId, Self::AccountData<Balance>> |
There was a problem hiding this comment.
Some docs on what this does would be nice.
There was a problem hiding this comment.
Please could you explain a little bit more on this, can I put the explanation above the updated code?
There was a problem hiding this comment.
sorry but doc still is not really sensible. You should explain the context, what options are available (store the data in this pallet or in system), which one is better, what tradeoff exists etc.
I really don't see any value in adding this one example block.
There was a problem hiding this comment.
I made an update to my initial pr @kianenigma
kianenigma
reviewed
Dec 4, 2021
kianenigma
suggested changes
Dec 4, 2021
|
Hey, is anyone still working on this? Due to the inactivity this issue has been automatically marked as stale. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
A5-stale
|
Ping @ECJ222 ? |
stale
bot
removed
the
A5-stale
|
Hi @bkchr, Hope you are doing good, I have been a little busy I will jump back on this issue. |
|
Can you please resolve the requested changes? |
|
Hey @bkchr, I have resolved your requested changes. |
bkchr
approved these changes
Jan 11, 2022
bkchr
reviewed
Jan 17, 2022
kianenigma
reviewed
Jan 25, 2022
kianenigma
reviewed
Jan 25, 2022
kianenigma
approved these changes
Jan 25, 2022
|
bot merge |
|
Waiting for commit status. |
|
@ECJ222 please run |
I have formatted my code changes @kianenigma 👍 |
bkchr
added
A2-insubstantial
eskimor
pushed a commit
that referenced
this pull request
Jan 27, 2022
* chore: modified example for balance AccountStore * add example for account store balance * add example for account store balance * Update frame/balances/src/lib.rs * Update frame/balances/src/lib.rs * balance account store example * balance account store example * Update frame/balances/src/lib.rs * Update frame/balances/src/lib.rs * balance account store example Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Kian Paimani <[email protected]>
Wizdave97
pushed a commit
to ComposableFi/substrate
that referenced
this pull request
Feb 4, 2022
* chore: modified example for balance AccountStore * add example for account store balance * add example for account store balance * Update frame/balances/src/lib.rs * Update frame/balances/src/lib.rs * balance account store example * balance account store example * Update frame/balances/src/lib.rs * Update frame/balances/src/lib.rs * balance account store example Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Kian Paimani <[email protected]>
grishasobol
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Mar 28, 2022
* chore: modified example for balance AccountStore * add example for account store balance * add example for account store balance * Update frame/balances/src/lib.rs * Update frame/balances/src/lib.rs * balance account store example * balance account store example * Update frame/balances/src/lib.rs * Update frame/balances/src/lib.rs * balance account store example Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Kian Paimani <[email protected]>
ark0f
pushed a commit
to gear-tech/substrate
that referenced
this pull request
Feb 27, 2023
* chore: modified example for balance AccountStore * add example for account store balance * add example for account store balance * Update frame/balances/src/lib.rs * Update frame/balances/src/lib.rs * balance account store example * balance account store example * Update frame/balances/src/lib.rs * Update frame/balances/src/lib.rs * balance account store example Co-authored-by: Bastian Köcher <[email protected]> Co-authored-by: Kian Paimani <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an example for balance AccountStore #6532.
13g44iYtkxLZ2tkp6iTJiqs7yEiEr4bVsPZTueWDjd6Bor1P