This repository was archived by the owner on Nov 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 38
New parity-keyring image
#426
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
600318a
Ignore env files
chevdor f5335ea
Allow customizing UID and GID
chevdor 93e2b4d
New image
chevdor 97d9dd3
Cleanup
chevdor 2753572
Update dockerfiles/parity-keyring/Dockerfile
chevdor 60cc0d3
Update dockerfiles/parity-keyring/Dockerfile
chevdor File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,2 @@ | ||
| .*.swp | ||
| .env |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| ARG REGISTRY_PATH=docker.io/paritytech | ||
|
|
||
| FROM docker.io/paritytech/gnupg:latest | ||
|
|
||
| # 'Parity Security Team <[email protected]>' | ||
| ARG KEY_ID=9D4B2B6EB8F97156D19669A9FF0812D491B96798 | ||
| ARG KEY_SERVER=hkps://keys.mailvelope.com | ||
| ARG VCS_REF=master | ||
| ARG BUILD_DATE="" | ||
|
|
||
| # metadata | ||
| LABEL summary="Base image with Parity-Keyring" \ | ||
| name="${REGISTRY_PATH}/parity-keyring" \ | ||
| maintainer="[email protected]" \ | ||
| version="1.0" \ | ||
| description="Parity Keyring base container" \ | ||
| io.parity.image.vendor="Parity Technologies" \ | ||
| io.parity.image.source="https://github.com/paritytech/scripts/blob/${VCS_REF}/dockerfiles/parity-keyring/Dockerfile" \ | ||
| io.parity.image.documentation="https://github.com/paritytech/scripts/blob/${VCS_REF}/dockerfiles/parity-keyring/README.md" \ | ||
| io.parity.image.revision="${VCS_REF}" \ | ||
| io.parity.image.created="${BUILD_DATE}" | ||
|
|
||
| USER root | ||
|
|
||
| RUN gpg --recv-keys --keyserver $KEY_SERVER $KEY_ID && \ | ||
| gpg --export $KEY_ID > /usr/share/keyrings/parity.gpg && \ | ||
| echo 'deb [signed-by=/usr/share/keyrings/parity.gpg] https://releases.parity.io/deb release main' > /etc/apt/sources.list.d/parity.list && \ | ||
| apt update && \ | ||
| apt install parity-keyring | ||
|
|
||
| USER nonroot:nonroot | ||
|
|
||
| RUN gpg /usr/share/keyrings/parity.gpg | grep -v expired | ||
|
|
||
| WORKDIR /home/nonroot | ||
| CMD ["/bin/bash"] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| # parity-keyring | ||
|
|
||
| A base Docker image based on [our gnupg image](https://hub.docker.com/repository/docker/paritytech/gnupg) and coming pre-installed with the parity keyring. | ||
|
|
||
| [Click here](https://hub.docker.com/repository/docker/paritytech/parity-keyring) for the registry. | ||
|
|
||
| ## Usage | ||
|
|
||
| ``` | ||
| docker run --rm -it docker.io/paritytech/parity-keyring gpg --list-keys $KEY_ID | ||
| ``` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: why make these args?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we had issues with the deb/rpm image signing due to running rootless and using the wrong UID.
For now, the change does nothing but an easy fix could be to align the UID of the image with our expectations in the cleanroom. That would be another PR then.