This repository was archived by the owner on Nov 4, 2024. It is now read-only.
New parity-keyring image
#426
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coderobe
suggested changes
Jun 1, 2022
Co-authored-by: Mara Robin B. <[email protected]>
Co-authored-by: Mara Robin B. <[email protected]>
coderobe
approved these changes
Jun 1, 2022
| ARG VCS_REF=master | ||
| ARG BUILD_DATE="" | ||
| ARG UID=1000 | ||
| ARG GID=1000 |
There was a problem hiding this comment.
Because we had issues with the deb/rpm image signing due to running rootless and using the wrong UID.
For now, the change does nothing but an easy fix could be to align the UID of the image with our expectations in the cleanroom. That would be another PR then.
EgorPopelyaev
approved these changes
Jun 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new image + few minor fixes.
Can be tested using (no need to define
KEY_ID, it is in the image):