Test cases as requested regarding issue #163 #164
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wiktor-k
added a commit
to wiktor-k/rust-cryptoki
that referenced
this pull request
Sep 12, 2023
Handling of empty data specified was broken. As specified in "2.1.7 PKCS parallaxsecond#1 RSA OAEP mechanism parameters" the `CKZ_DATA_SPECIFIED` source: > Array of CK_BYTE containing the value of the encoding parameter. > If the parameter is empty, pSourceData must be NULL and ulSourceDataLen > must be zero. Adjusts by returning `std::ptr::null()` when the source data has not been specified (`PkcsOaepSource::empty()` was used) and adds a tests case for this. One more test case that is ignored is added to handle the case when the data specified is non-empty. Unfortunately this test fails for unknown reasons (I haven't been able to find if SoftHSM supports it or not). Fixes: parallaxsecond#163 Fixes: parallaxsecond#164 Signed-off-by: Wiktor Kwapisiewicz <[email protected]> Co-authored-by: Nachiketh S Ujjainimath <[email protected]>
ionut-arm
pushed a commit
that referenced
this pull request
Sep 25, 2023
Handling of empty data specified was broken. As specified in "2.1.7 PKCS #1 RSA OAEP mechanism parameters" the `CKZ_DATA_SPECIFIED` source: > Array of CK_BYTE containing the value of the encoding parameter. > If the parameter is empty, pSourceData must be NULL and ulSourceDataLen > must be zero. Adjusts by returning `std::ptr::null()` when the source data has not been specified (`PkcsOaepSource::empty()` was used) and adds a tests case for this. One more test case that is ignored is added to handle the case when the data specified is non-empty. Unfortunately this test fails for unknown reasons (I haven't been able to find if SoftHSM supports it or not). Fixes: #163 Fixes: #164 Signed-off-by: Wiktor Kwapisiewicz <[email protected]> Co-authored-by: Nachiketh S Ujjainimath <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am bundling the code along with the softhsm portable version which isn't required if softhsm already exists in the system. The Test cases are in src/bin folder.
Please let me know if i need to provide any more info to help recreate the issue. Thank you