Fix RSA OKCS OAEP mechanism #165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handling of empty data specified was broken. As specified in "2.1.7 PKCS parallaxsecond#1 RSA OAEP mechanism parameters" the `CKZ_DATA_SPECIFIED` source: > Array of CK_BYTE containing the value of the encoding parameter. > If the parameter is empty, pSourceData must be NULL and ulSourceDataLen > must be zero. Adjusts by returning `std::ptr::null()` when the source data has not been specified (`PkcsOaepSource::empty()` was used) and adds a tests case for this. One more test case that is ignored is added to handle the case when the data specified is non-empty. Unfortunately this test fails for unknown reasons (I haven't been able to find if SoftHSM supports it or not). Fixes: parallaxsecond#163 Fixes: parallaxsecond#164 Signed-off-by: Wiktor Kwapisiewicz <[email protected]> Co-authored-by: Nachiketh S Ujjainimath <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
Signed-off-by: Wiktor Kwapisiewicz <[email protected]>
|
Thank you so much for your quick response and fix! |
No problem. I surveyed existing alternative implementations and started changing stuff here and there and finally your test case succeeded. Thanks for submitting it as this was the critical factor that allowed me to quickly check various things. (Note that it may take some time until it's reviewed and a new version of the crate is released to crates.io) See you later! 👋 |
hug-dev
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling of empty data specified was broken.
As specified in "2.1.7 PKCS #1 RSA OAEP mechanism parameters" the
CKZ_DATA_SPECIFIEDsource:Adjusts by returning
std::ptr::null()when the source data has not been specified (PkcsOaepSource::empty()was used) and adds a tests case for this.One more test case that is ignored is added to handle the case when the data specified is non-empty. Unfortunately this test fails for unknown reasons (I haven't been able to find if SoftHSM supports it or not).
Fixes: #163
Fixes: #164