Skip to content

TYP: tighten return type in function any #46638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 7, 2022
Merged

TYP: tighten return type in function any #46638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b82c810
readd changes in frame, series without actual implementations
yadav-sachin Apr 4, 2022
f40bb8c
update return types in generic.py
yadav-sachin Apr 4, 2022
f7c111a
Merge remote-tracking branch 'upstream/main' into any_return_type2
yadav-sachin Apr 15, 2022
426d7e7
add overload defs for level
yadav-sachin May 1, 2022
4db60ca
Merge remote-tracking branch 'upstream/main' into any_return_type2
yadav-sachin May 1, 2022
0fbd541
remove keyword-args constraint in generic
yadav-sachin May 2, 2022
c0bc37d
fix typo in overload defs
yadav-sachin May 6, 2022
0f75782
add error comments above func defs
yadav-sachin May 6, 2022
d27fdc0
remove self annotations, * in implement, add type ignore
yadav-sachin May 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions pandas/core/frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8988,6 +8988,42 @@ def aggregate(self, func=None, axis: Axis = 0, *args, **kwargs):

agg = aggregate

# error: Signature of "any" incompatible with supertype "NDFrame" [override]
@overload # type: ignore[override]
def any(
self,
*,
axis: Axis = ...,
bool_only: bool | None = ...,
skipna: bool = ...,
level: None = ...,
**kwargs,
) -> Series:
...

@overload
def any(
self,
*,
axis: Axis = ...,
bool_only: bool | None = ...,
skipna: bool = ...,
level: Level,
**kwargs,
) -> DataFrame | Series:
...

@doc(NDFrame.any, **_shared_doc_kwargs)
def any(
self,
axis: Axis = 0,
bool_only: bool | None = None,
skipna: bool = True,
level: Level | None = None,
**kwargs,
) -> DataFrame | Series:
...

@doc(
_shared_docs["transform"],
klass=_shared_doc_kwargs["klass"],
Expand Down
36 changes: 36 additions & 0 deletions pandas/core/series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4397,6 +4397,42 @@ def aggregate(self, func=None, axis=0, *args, **kwargs):

agg = aggregate

# error: Signature of "any" incompatible with supertype "NDFrame" [override]
@overload # type: ignore[override]
def any(
self,
*,
axis: Axis = ...,
bool_only: bool | None = ...,
skipna: bool = ...,
level: None = ...,
**kwargs,
) -> bool:
...

@overload
def any(
self,
*,
axis: Axis = ...,
bool_only: bool | None = ...,
skipna: bool = ...,
level: Level,
**kwargs,
) -> Series | bool:
...

@doc(NDFrame.any, **_shared_doc_kwargs)
def any(
self,
axis: Axis = 0,
bool_only: bool | None = None,
skipna: bool = True,
level: Level | None = None,
**kwargs,
) -> Series | bool:
...

@doc(
_shared_docs["transform"],
klass=_shared_doc_kwargs["klass"],
Expand Down