TYP: tighten return type in function any #46638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
twoertwein
reviewed
Apr 5, 2022
MarcoGorelli
suggested changes
May 1, 2022
Contributor
Author
|
An entry in the whatsnew is not required for this, right? |
twoertwein
reviewed
May 6, 2022
twoertwein
approved these changes
May 6, 2022
Member
twoertwein
left a comment
twoertwein
left a comment
There was a problem hiding this comment.
Thank you @yadav-sachin! Except for the small comment, it looks good to me.
Looking forward to @MarcoGorelli's cat GIF :)
twoertwein
reviewed
May 6, 2022
twoertwein
approved these changes
May 7, 2022
Member
twoertwein
left a comment
twoertwein
left a comment
There was a problem hiding this comment.
Great, thank you @yadav-sachin!
Contributor
Author
|
Thanks @twoertwein @MarcoGorelli for the reviews. Waiting for more Cat GIFs. 😺
|
Member
|
😄 the gifs on approval are from https://youtu.be/2rDNJvHznrM |
yehoshuadimarsky
pushed a commit
to yehoshuadimarsky/pandas
that referenced
this pull request
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
anyreturn type #44802doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Continuing remaining work after Pull request #44896.
DataFrame.anythe return type should be DataFrame or Series, and forSeries.anythe return type should be Series or bool.