Skip to content

DOC: update guideline for installation development environment using pip #40598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Mar 24, 2021
Merged

DOC: update guideline for installation development environment using pip #40598

Changes from 10 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7e461a1
remove \n from docstring
charlesdong1991 Dec 3, 2018
1314059
fix conflicts
charlesdong1991 Jan 19, 2019
8bcb313
Merge remote-tracking branch 'upstream/master'
charlesdong1991 Jul 30, 2019
24c3ede
Merge remote-tracking branch 'upstream/master'
charlesdong1991 Jan 14, 2020
dea38f2
fix issue 17038
charlesdong1991 Jan 14, 2020
cd9e7ac
revert change
charlesdong1991 Jan 14, 2020
e5e912b
revert change
charlesdong1991 Jan 14, 2020
045a76f
Merge remote-tracking branch 'upstream/master'
charlesdong1991 Apr 6, 2020
ddd37dc
Merge remote-tracking branch 'upstream/master'
Mar 23, 2021
06b71af
update contributing doc
Mar 23, 2021
ad04770
update on review
Mar 24, 2021
a5abad2
rephrase docs
Mar 24, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion doc/source/development/contributing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,10 @@ Creating a Python environment (pip)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

If you aren't using conda for your development environment, follow these instructions.
You'll need to have at least Python 3.6.1 installed on your system.
You'll need to have at least Python 3.6.1 installed on your system. If your Python version
Copy link
Member

@MarcoGorelli MarcoGorelli Mar 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.7 now?

Copy link
Contributor Author

@charlesdong1991 charlesdong1991 Mar 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Updated!

Copy link
Member

@MarcoGorelli MarcoGorelli Mar 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, just noticed there's already #40552 open to address the 3.6.1 issue, sorry for my irrelevant comment

is 3.8.0 (or later), make sure to update your `setuptools` to version 42.0.0 (or later)::

pip install --upgrade setuptools

**Unix**/**macOS with virtualenv**

Expand Down