DOC: Fix minimum Python version in contributing docs #40552
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hasan-yaman
commented
Mar 21, 2021
hasan-yaman
commented
- closes DOC: Outdated Python version in contributing docs #40485
Contributor
Author
|
I think the failed check also fails in the current master. So, what should I do? |
Contributor
nothing. just wait. it might get approved without, or you might be asked to rebase when master goes green again (gets fixed) |
Contributor
Author
|
Thanks for the explanation. |
4 tasks
Member
|
Hi @hasan-yaman - could you fetch and merge upstream/master please? |
Member
|
Thanks @hasan-yaman for updating - let's just wait for #40130 to be in before proceeding here |
Member
|
#40130 is in - @hasan-yaman if you rebase and ping when ready this should be good to go |
Contributor
Author
|
I moved the changes to contributing_environment.rst Thanks for your help. |
MarcoGorelli
approved these changes
Apr 4, 2021
Member
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
Thanks @hasan-yaman , looks good to me pending green
vladu
pushed a commit
to vladu/pandas
that referenced
this pull request
Apr 5, 2021
* DOC: Fix minimum Python version in contributing docs * DOC: Fix minimum Python version in contributing environment docs
JulianWgs
pushed a commit
to JulianWgs/pandas
that referenced
this pull request
Jul 3, 2021
* DOC: Fix minimum Python version in contributing docs * DOC: Fix minimum Python version in contributing environment docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.