BUG: fix length_of_indexer with boolean mask #31897
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrockmendel
changed the title
jbrockmendel
added
the
Indexing
jreback
requested changes
Feb 13, 2020
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
is this a bug fix? (the OP was)
Member
Author
Only sorta-kinda. The current behavior is wrong (assuming im correctly interpreting the desired behavior as "give the expected length of obj[indexer]"), but AFAICT nothing user-facing. |
Member
Author
|
gentle ping (for this and #31887). i think ive got a handle on the brokenness of _setitem_with_indexer and would like to get these simplications in before ripping apart whats left |
roberthdevries
pushed a commit
to roberthdevries/pandas
that referenced
this pull request
Mar 2, 2020
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffAllows for a nice cleanup in _setitem_with_indexer. Note this will conflict with #31887; the order doesn't matter.